On Wed, 14 Dec 2022 11:53:30 GMT, Daniel Fuchs <[email protected]> wrote:
>> The test has been observed failing once in the CI, on windows, with a >> BindException (address already in use) on the client side. This usually >> means that the system has run out of ephemeral ports or file descriptors. >> The proposed fix will catch the BindException, run the gc, wait a bit, and >> retry once. No guarantee that this will actually work - but maybe worth a >> try, though I worry a bit the authentication count might get wrong if the >> request that gets the BindException is the first one that follows the >> 401/407 response - in case the connection was closed after receiving >> 401/407. Since we have no visibility of which call to connect() fails, it is >> hard to cater for this possibility without making the test too permissive. >> >> The alternative would be to throw a SkipException in case BindException is >> received. >> >> While working on the fix I noticed that some parts of the test had been >> commented out waiting for a RFE to be implemented. Since the RFE has been >> implemented since then, I went out and uncommented that part of the test. >> >> Comments welcome. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into HTTPSetAuthenticatorTest-8296610 > - Increased wait time and added more debug info > - 8296610 LGTM ------------- Marked as reviewed by michaelm (Reviewer). PR: https://git.openjdk.org/jdk/pull/11634
