On Mon, 12 Dec 2022 14:50:21 GMT, Daniel Fuchs <[email protected]> wrote:
> The test has been observed failing once in the CI, on windows, with a > BindException (address already in use) on the client side. This usually means > that the system has run out of ephemeral ports or file descriptors. The > proposed fix will catch the BindException, run the gc, wait a bit, and retry > once. No guarantee that this will actually work - but maybe worth a try, > though I worry a bit the authentication count might get wrong if the request > that gets the BindException is the first one that follows the 401/407 > response - in case the connection was closed after receiving 401/407. Since > we have no visibility of which call to connect() fails, it is hard to cater > for this possibility without making the test too permissive. > > The alternative would be to throw a SkipException in case BindException is > received. > > While working on the fix I noticed that some parts of the test had been > commented out waiting for a RFE to be implemented. Since the RFE has been > implemented since then, I went out and uncommented that part of the test. > > Comments welcome. This pull request has now been integrated. Changeset: 0dce5b81 Author: Daniel Fuchs <[email protected]> URL: https://git.openjdk.org/jdk/commit/0dce5b811d64ac17b9580d6a2d8eca1df70990a1 Stats: 60 lines in 2 files changed: 30 ins; 0 del; 30 mod 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect" Reviewed-by: michaelm ------------- PR: https://git.openjdk.org/jdk/pull/11634
