On Wed, 18 Jan 2023 07:13:10 GMT, Jaikiran Pai <[email protected]> wrote:
>> The MappingResponseSubscriber test has been observed failing on windows in >> our CI due to a ConnectException. >> I am suspecting that some kind of connection limit enforced by the system >> has been reached. >> We can see from the log that the TCP connection has failed, been retried, >> and failed again. >> Previous connections to the same server seem to have succeeded. >> >> Modifying the test to wait after previous clients have been GC'ed before >> opening the next one could alleviate the situation. > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java line 149: > >> 147: System.gc(); >> 148: AssertionError error = TRACKER.check(tracker, 1500); >> 149: if (error != null) throw error; > > Hello Daniel, in theory, this could potentially lose the any original > failure/exception that the test in the try block might have raised. Perhaps > we could catch and throw the original exception and add this additional > failure as a suppressed exception to it? Good point! Let me fix that. ------------- PR: https://git.openjdk.org/jdk/pull/12013
