On Wed, 18 Jan 2023 11:11:39 GMT, Daniel Fuchs <[email protected]> wrote:
>> The MappingResponseSubscriber test has been observed failing on windows in >> our CI due to a ConnectException. >> I am suspecting that some kind of connection limit enforced by the system >> has been reached. >> We can see from the log that the TCP connection has failed, been retried, >> and failed again. >> Previous connections to the same server seem to have succeeded. >> >> Modifying the test to wait after previous clients have been GC'ed before >> opening the next one could alleviate the situation. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into MappingResponseSubscriber-8300172 > - Original exception might be lost with try-finally > - 8300172 This now looks fine to me. Sorry, I previously thought I had added comment about copyright year needing an update, but looks like I didn't. Please update the copyright year before integrating. ------------- Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/12013
