On Wed, 8 Feb 2023 10:51:50 GMT, Jaikiran Pai <[email protected]> wrote:

> A general comment about the new test is that, as far as I am aware, we no 
> longer use the bug id specific test directories. So maybe we should move the 
> new test to the top level under `test/jdk/java/net/httpclient` directory 
> itself. The `HttpServerAccess` test utility class, could perhaps just be a 
> nested class within the test?
> 
> Both of these are minor suggestions. If you prefer to use this current 
> structure, that's fine with me.

Thanks for the suggestion, I'll move them to the top level, though thinking 
about it I may have more tests in the near future that could use 
`HttpServerAccess` so I may leave it as its own class

-------------

PR: https://git.openjdk.org/jdk/pull/12413

Reply via email to