On Wed, 8 Feb 2023 11:50:55 GMT, Darragh Clarke <[email protected]> wrote:

> A general comment about the new test is that, as far as I am aware, we no 
> longer use the bug id specific test directories. So maybe we should move the 
> new test to the top level under `test/jdk/java/net/httpclient` directory 
> itself. The `HttpServerAccess` test utility class, could perhaps just be a 
> nested class within the test?

I don't think that would work. AFAIU HttpServerAccess needs to be injected into 
the jdk.httpserver module by jtreg so it can't be a nested class. And since we 
don't want every test in the parent directory to run with this class injected 
into the httpserver module I believe we need the new test to be in its own 
subdirectory. I don't mind changing the name of that directory though :-)

-------------

PR: https://git.openjdk.org/jdk/pull/12413

Reply via email to