On Wed, 8 Mar 2023 11:01:07 GMT, Jaikiran Pai <[email protected]> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use HashSet.newHashSet(capacity)
>
> test/jdk/java/net/httpclient/DebugLoggerTest.java line 242:
> 
>> 240:         out =  new RecordingPrintStream(stdOut, true, UTF_8);
>> 241:         System.setErr(err);
>> 242:         System.setOut(out);
> 
> Should we reset these back to their original streams in a `finally` block?

The test runs in /othervm and the RecordingPrintStream acts like a `tee` so it 
should not matter.

-------------

PR: https://git.openjdk.org/jdk/pull/12900

Reply via email to