On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs <[email protected]> wrote:

> The HttpClient internal DebugLogger could be simplified if its configuration 
> was held in a record. Some of the methods in Utils that return a debug logger 
> could also be simplified/removed. The system property that configures the 
> debug logging could be extended to choose between System.err, System.out, 
> System.Logger, or any of these configurations.
> Passing -Djdk.internal.httpclient.debug=true still works as before.

src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java line 
975:

> 973:      */
> 974:     public static Logger getWebSocketLogger(Supplier<String> dbgTag) {
> 975:         return DebugLogger.createWebSocketLogger(dbgTag, DEBUG_CONFIG);

I think this should should be:


return DebugLogger.createWebSocketLogger(dbgTag, DEBUG_WS_CONFIG);

i.e. `DEBUG_WS_CONFIG` instead of `DEBUG_CONFIG`

-------------

PR: https://git.openjdk.org/jdk/pull/12900

Reply via email to