On Tue, 4 Apr 2023 17:02:08 GMT, Darragh Clarke <d...@openjdk.org> wrote:
> Currently it is possible for `HttpURLConnection` with the `Expect: > 100-Continue` header to timeout awaiting for a server response. According to > [RFC-7231](https://www.rfc-editor.org/rfc/rfc7231#section-5.1.1) a client > `SHOULD NOT wait for an indefinite period before sending the message body`. > > This PR changes the existing `expect100Continue` method to wait for a maximum > of 5 seconds for a server response, this will be shorter if a timeout is set. > If no response is received, the message is sent regardless. > > Tests have been added to account for different scenarios that currently > timeout, and the changes have been tested against tiers 1,2 and 3. test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java line 193: > 191: control.write100ContinueTwice = false; > 192: > 193: HttpURLConnection connection = (HttpURLConnection) > url.openConnection(); Hi Darragh, It looks like the tests share a lot of similar code, unless there is a reason not to, could they not share a similar function to reduce code duplication? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13330#discussion_r1158026653
