On Wed, 5 Apr 2023 07:15:43 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Currently it is possible for `HttpURLConnection` with the `Expect: >> 100-Continue` header to timeout awaiting for a server response. According to >> [RFC-7231](https://www.rfc-editor.org/rfc/rfc7231#section-5.1.1) a client >> `SHOULD NOT wait for an indefinite period before sending the message body`. >> >> This PR changes the existing `expect100Continue` method to wait for a >> maximum of 5 seconds for a server response, this will be shorter if a >> timeout is set. If no response is received, the message is sent regardless. >> >> Tests have been added to account for different scenarios that currently >> timeout, and the changes have been tested against tiers 1,2 and 3. > > src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java > line 1370: > >> 1368: } >> 1369: >> 1370: http.setIgnoreContinue(true); > > Do you still need the `setIgnoreContinue(true)` in line 1339? Thanks for pointing those out, I accidentally doubled up on `setIgnoreContinue` calls ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13330#discussion_r1158311150
