On Wed, 28 Jun 2023 11:15:53 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review for this change which proposes to address > https://bugs.openjdk.org/browse/JDK-8311032? > > The commit in this PR skips the class lookups when the package name prefix is > empty, either due to the `java.protocol.handler.pkgs` system property value > being empty or due to individual parts of the `|` delimited value being empty. > > This avoids potentially expensive classloading attempts for a class name of > the form `.foo.Handler`, which is bound to fail. > > No new jtreg test has been added given the nature of the change. There's > already an existing test > `test/jdk/java/net/URL/HandlersPkgPrefix/HandlersPkgPrefix.java` which tests > different values for the `java.protocol.handler.pkgs` system property > (including empty value) and that test continues to pass with this change. > > tier testing is currently in progress. This pull request has now been integrated. Changeset: 8f5a3848 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/8f5a38488c354b21f1033e1cbdfa0a400f2622fc Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8311032: Empty value for java.protocol.handler.pkgs system property can lead to unnecessary classloading attempts of protocol handlers Reviewed-by: dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/14693
