On Fri, 28 Jul 2023 15:57:50 GMT, Thomas Obermeier <[email protected]> wrote:
> exclude multicast and related tests on AIX mentioned in > https://bugs.openjdk.org/browse/JDK-8308807 until this is fixed. Hi Thomas, seems okay mostly, small nits remain, see inline remarks. BTW you can test this on AIX via `jtreg -exclude:<problemlist file> -l <tests>`. [1] I often do this since I keep getting the Problemlist syntax wrong. Cheers, Thomas [1] https://openjdk.org/jtreg/command-help.html test/jdk/ProblemList.txt line 537: > 535: java/net/MulticastSocket/Test.java > 7145658,8308807 macosx-all,aix-ppc64 > 536: > 537: java/net/ServerSocket/AcceptInheritHandle.java > 8211854,8308807 aix-ppc64 Needed? Test was not mentioned in JDK-8308807. test/jdk/ProblemList.txt line 797: > 795: > ############################################################################ > 796: > 797: # jdk_foreign Please remove this hunk ------------- Changes requested by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15074#pullrequestreview-1552807591 PR Review Comment: https://git.openjdk.org/jdk/pull/15074#discussion_r1278007969 PR Review Comment: https://git.openjdk.org/jdk/pull/15074#discussion_r1278005685
