On Mon, 31 Jul 2023 10:06:57 GMT, Thomas Obermeier <[email protected]> wrote:
>> The heading on the sections are usually test group names so "jdk_foreign" is >> correct, but I don't know what this change is doing in this PR. > > So if @AlanBateman does not insist, I'd keep it as is and hopefully rember > for next time ;-) I don't have a string opinion either way. I think the main thing is that I suspect you'll need to exclude more tests as there are several tests for DatagramChannel that join multicast groups and some of these likely assume they can join an IPv4 multicast group when cases where the DatagramChannel is created with the no-arg open method (and IPv6 is enabled) or with the IPV6 protocol family. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15074#discussion_r1279112938
