On Mon, 9 Oct 2023 13:43:41 GMT, Daniel Fuchs <[email protected]> wrote:
>> Conor Cleary has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits since the last revision:
>>
>> - 8309118: Fixed error in handleReset ReentrantLock
>> - 8309118: Updates to Stream cancelImpl
>> - 8309118: Refactored test, updated incoming_reset
>> - Merge branch 'master' into JDK-8309118
>> - 8309118: Cleanup identifiers and whitespace
>> - 8309118: Removed unused try-with-resources
>> - 8309118: Improve comments and annotations
>> - 8309118: Remove local test timeout value
>> - 8309118: Add more tests for 100 ExpectContinue with HTTP/2
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 635:
>
>> 633: closed = true;
>> 634: } finally {
>> 635: stateLock.unlock();
>
> Ouch! I am to blame for this one. It's a regression introduced by
> JDK-8308310. This one needs to be backported to JDK 21. Let me see if I
> should prepare a PR for that.
https://github.com/openjdk/jdk/pull/16101
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15664#discussion_r1350342203
