On Mon, 23 Oct 2023 14:11:50 GMT, Daniel Fuchs <[email protected]> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> schedule completes normally on NO_ERROR, incoming_reset safely accesses
>> volataile
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 619:
>
>> 617: }
>> 618: if (!endStreamSeen) {
>> 619: // If no END_STREAM flag seen, any RST_STREAM should be
>> handled here immediately
>
> Suggestion:
>
> if (!endStreamSeen || !finalResponseCodeReceived) {
> // If no END_STREAM flag seen, any RST_STREAM should be
> handled here immediately
> // If the final response code was not received, then we
> should also handle
> // the RST_STREAM immediately
So by checking if the final response code is received, this makes sure that the
entire block of headers is processed therfore a status code will have been
received.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15664#discussion_r1369875187
