On Fri, 20 Oct 2023 12:00:51 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed correctly. >> >> The proposed code does not percent-encode the IPv6 addresses at all. >> >> Added a test to verify that different forms of addresses are processed >> correctly. The test verifies the handling of IPv4 addresses, IPv6 without >> scope, IPv6 with numeric scope, IPv6 with textual scope (only if present on >> the machine running tests), hostnames and FQDNs >> >> Tier1-3 tests passed. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Remove redundant checks Marked as reviewed by jpai (Reviewer). I just noticed that the test isn't marked `othervm` but changes the JVM level `ProxySelector` in its test execution. I think we should mark it `othervm` to avoid interfering (or being interefered) by other tests. ------------- PR Review: https://git.openjdk.org/jdk/pull/16265#pullrequestreview-1692570325 PR Comment: https://git.openjdk.org/jdk/pull/16265#issuecomment-1775214223
