On Mon, 23 Oct 2023 14:29:59 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> This patch fixes the encoding of IPv6 addresses in the URI provided to >> ProxySelector. >> >> The original code percent-encoded the square brackets added around the IPv6 >> addresses, producing URIs that could not be parsed correctly. >> >> The proposed code does not percent-encode the IPv6 addresses at all. >> >> Added a test to verify that different forms of addresses are processed >> correctly. The test verifies the handling of IPv4 addresses, IPv6 without >> scope, IPv6 with numeric scope, IPv6 with textual scope (only if present on >> the machine running tests), hostnames and FQDNs >> >> Tier1-3 tests passed. > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - Run test in othervm > - Remove leftover comment The changes and the new test look good to me. ------------- Marked as reviewed by aefimov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16265#pullrequestreview-1692749800
