On Tue, 20 Feb 2024 10:10:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review for this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8326233? >> >> As noted in the issue, when the `java.net.HttpClient.Builder` is configured >> with a `SSLParameters` instance whose `needClientAuth` is set to true, then >> it is expected that the `HttpClient` that's built from such a build will >> have its `SSLParameters` with `needClientAuth` as `true` and >> `wantClientAuth` as `false`. But due to a bug in the internal implementation >> of a the `HttpClient`, the value for `needClientAuth` was getting reset to >> `false`. The commit in this PR fixes that issue and introduces a jtreg tests >> which reproduces the issue and verifies the fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Daniel's review - remove "final" test/jdk/java/net/httpclient/HttpClientBuilderTest.java line 283: > 281: } > 282: // needClientAuth = true and thus wantClientAuth = false > 283: final SSLParameters needClientAuthParams = new SSLParameters(); You may also want to remove `final` at this line and line 293, though this is just be a test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17923#discussion_r1495642530
