On Tue, 20 Feb 2024 12:51:15 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review for this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8326233? >> >> As noted in the issue, when the `java.net.HttpClient.Builder` is configured >> with a `SSLParameters` instance whose `needClientAuth` is set to true, then >> it is expected that the `HttpClient` that's built from such a build will >> have its `SSLParameters` with `needClientAuth` as `true` and >> `wantClientAuth` as `false`. But due to a bug in the internal implementation >> of a the `HttpClient`, the value for `needClientAuth` was getting reset to >> `false`. The commit in this PR fixes that issue and introduces a jtreg tests >> which reproduces the issue and verifies the fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > remove "final" from test Why do I have this feeling of déjà vu? I thought we had fixed that already... LGTM. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17923#pullrequestreview-1890549722
