On Fri, 23 Feb 2024 16:59:12 GMT, Daniel Jeliński <[email protected]> wrote:
> Please review this patch that removes the specification of system properties > that are no longer used: > - `http.auth.digest.cnonceRepeat` system property was removed in JDK 5 > - `java.net.socks.username` and `java.net.socks.password` were never > available as system properties; they were available as user preferences. The > support for these preferences was removed in JDK 7. > > Additionally I updated the SOCKS proxy specification to match the user guide, > and added the information that SOCKS proxies are only used by java.net TCP > connections; the NIO SocketChannel does not support SOCKS proxies. src/java.base/share/classes/java/net/doc-files/net-properties.html line 129: > 127: <LI><P>SOCKS<BR>The SOCKS proxy enables a lower-level type of tunneling > 128: because it works at the TCP level. Specifying a SOCKS proxy server > 129: results in all java.net TCP connections going through that proxy server Maybe the "all java.net TCP connections" part should be reworked, to simply say that SOCKS proxy may not always be supported out-of-the-box depending on the type of connections. There you could cite NIO SocketChannel and java.net.http.HttpClient. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17988#discussion_r1502399049
