On Thu, 29 Feb 2024 15:27:47 GMT, Daniel Jeliński <[email protected]> wrote:

>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 155:
>> 
>>> 153:                        '*' can be used for pattern matching. For 
>>> example,
>>> 154:                        {@code 
>>> -DsocksNonProxyHosts="*.foo.com|localhost"}
>>> 155:                        will indicate that every host in the foo.com 
>>> domain and the
>> 
>> Suggestion:
>> 
>>                      will indicate that every host in the foo.com domain 
>> (excluding sub-domains) and the
>
> could you remind me what sub-domains mean in this context?
> For reference, `*.foo.bar` will match `www.foo.bar` and `a.b.c.foo.bar`, but 
> not `foo.bar`; internally `*` matches any string, including dots.

In that case, please ignore the suggestion. It is fine as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17988#discussion_r1507820421

Reply via email to