On Fri, 23 Feb 2024 03:08:51 GMT, John Jiang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> undo changes to SimpleSSLContext in test library > > test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 114: > >> 112: needClientAuthParams.setWantClientAuth(initialWantClientAuth); >> 113: // needClientAuth = true and thus wantClientAuth = false >> 114: needClientAuthParams.setNeedClientAuth(true); > > I just want to clarify that these new cases look not suggested by my previous > comment. > > In my suggested cases, as shown as the below, > > setNeedClientAuth(true); > setWantClientAuth(false); > > > setWantClientAuth(true); > setNeedClientAuth(false); > > this first setting takes a state (`needClientAuth` or `wantClientAuth`) to > `true`, and the second setting takes both states to `false`. > Before this fix, the second setting doesn't reset the `true` state specified > by the first setting to `false`. > > Of course, if you think it's unnecessary to cover these corner cases, please > feel free to ignore them. Hello John, it wasn't clear to me previously that this is the specific test you were suggesting. I have now updated the PR to introduce this additional test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17940#discussion_r1502465926
