> Currently this test occasionally doesn't cleanup between runs, sometimes not > stopping the server or leaving Streams open > > Changes: > - Use try-with-resources to ensure streams close. > - Use try-finally to make sure the server stops before the test exits. > > I ran tiers 1-3 and ran this specific test on repeat and everything seems > stable after the changes
Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision: implemented feedback ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18514/files - new: https://git.openjdk.org/jdk/pull/18514/files/8e0374e0..1294dbc0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18514&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18514&range=00-01 Stats: 12 lines in 1 file changed: 1 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/18514.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18514/head:pull/18514 PR: https://git.openjdk.org/jdk/pull/18514
