On Mon, 8 Apr 2024 15:34:11 GMT, Darragh Clarke <[email protected]> wrote:
>> Currently this test occasionally doesn't cleanup between runs, sometimes not >> stopping the server or leaving Streams open >> >> Changes: >> - Use try-with-resources to ensure streams close. >> - Use try-finally to make sure the server stops before the test exits. >> >> I ran tiers 1-3 and ran this specific test on repeat and everything seems >> stable after the changes > > Darragh Clarke has updated the pull request incrementally with one additional > commit since the last revision: > > implementing feedback Thanks! LGTM now. Thanks. LGTM now. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18514#pullrequestreview-1988987958 PR Review: https://git.openjdk.org/jdk/pull/18514#pullrequestreview-1988990606
