On Wed, 15 May 2024 11:07:05 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reword the javadoc
>
> src/java.base/share/classes/java/net/SocketOptions.java line 197:
>
>> 195: * {@link #setOption(int, Object)}, can either be a {@linkplain
>> Boolean#FALSE Boolean.FALSE}
>> 196: * or an integer value. {@code Boolean.FALSE} represents that this
>> option is disabled whereas
>> 197: * an integer value represents the linger timeout.
>
> When the value is an integer then a positive integer enables, a negative
> integer disables. I think you'll have to work that into the wording.
Hello Alan, I had a look at the code which deals with this option. Based on
that I've updated the PR to reword this documentation. Is this accurate now?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19243#discussion_r1604376009
