On Fri, 17 May 2024 08:32:07 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reword the javadoc
>
> src/java.base/share/classes/java/net/SocketOptions.java line 197:
>
>> 195: * can be passed to {@link #setOption(int, Object)} to disable this
>> option. An integer
>> 196: * value {@code >= 0} passed to {@code setOption(int, Object)} will
>> enable the option and
>> 197: * the value will represent the linger timeout.
>
> I think the wording could be improved a bit with "Set the value to
> Boolean.FALSE or an integer less than 0 with setOption to disable this
> option".
Done. I've updated the PR with that suggested wording. I decided to let the
part which explains that an integer >=0 enables this option stay. I hope that's
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19243#discussion_r1604568594
