On Wed, 29 May 2024 00:59:10 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which marks 2 constructors on > `java.net.Socket` as deprecated for removal? > > As noted in https://bugs.openjdk.org/browse/JDK-8216984 these 2 `Socket` > constructors, which allow for `stream=false` to construct a UDP socket, have > been deprecated since several releases (starting Java 1.1). > `java.net.DatagramSocket` has been a standard API for dealing with UDP > sockets as noted in the already existing deprecation note on these > constructors. > > The commit in this PR marks these constructs as deprecated for removal to > allow for their removal in some future release. > > No new tests have been added for this change. tier1, tier2 and tier3 testing > is currently in progress. > > A CSR for this change is available at > https://bugs.openjdk.org/browse/JDK-8333092 I'm wondering about SocketImpl.create(boolean). We can't deprecate this method but maybe we should add a note to its API docs to say that Socket constructors to create a datagram socket is deprecated. If we do remove the constructors then I think SocketImpl.create(boolean) will be changed to throw UOE if the value of the parameter is false. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19441#issuecomment-2136530119
