On Wed, 29 May 2024 06:25:44 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which marks 2 constructors on >> `java.net.Socket` as deprecated for removal? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8216984 these 2 `Socket` >> constructors, which allow for `stream=false` to construct a UDP socket, have >> been deprecated since several releases (starting Java 1.1). >> `java.net.DatagramSocket` has been a standard API for dealing with UDP >> sockets as noted in the already existing deprecation note on these >> constructors. >> >> The commit in this PR marks these constructs as deprecated for removal to >> allow for their removal in some future release. >> >> No new tests have been added for this change. tier1, tier2 and tier3 testing >> is currently in progress. >> >> A CSR for this change is available at >> https://bugs.openjdk.org/browse/JDK-8333092 > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > reword the SocketImpl.create(...) note Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19441#pullrequestreview-2084405740
