On Sun, 17 Nov 2024 06:35:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert method description changes for getHardwareAddress
>
> src/java.base/share/classes/java/net/NetworkInterface.java line 513:
>
>> 511: *
>> 512: * @return a byte array containing the address, or {@code null} if
>> 513: * the address doesn't exist
>
> "accessed given the current privileges" relates to OS privileges/capabilities
> so not security manager related. So I think drop the change the method
> description, only change to this method should be the removal of the SM
> permission check.
Okay, so "not only security manager related then" :-) The current
implementation does return null on checkPermission failure, but yes, there are
other ways null may be returned.
I'll remove the method description changes and update the CSR as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22177#discussion_r1845347417
