On Sun, 17 Nov 2024 09:28:47 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this PR which cleans up SecurityManager related code from >> `java.net.NetworkInterface` after JEP-486. >> >> The specification of three methods in NetworkInterface is updated to reflect >> that these methods no longer use `SecurityManager` to filter their results >> such that a subset may be returned. A CSR draft has been proposed to fix >> this leftover from JEP-486. >> >> The actual SecurityManager cleanup: >> >> * The `getCheckedInetAddresses` method is removed. >> * `getInetAddresses` is updated to return `enumerationFromArray(addrs)` >> (with no filtering) >> * `inetAddresses` is update to return `streamFromArray(addrs)` (with no >> filtering) >> * `getInterfaceAddresses` is updated to return the list of >> InterfaceAddresses (with no filtering) >> * `getHardwareAddress` is updated to return the result with no permission >> checking >> * Three c-style array declarations hurt my eyes and were updated (sorry!) >> >> GHA and tier2 results pending. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Revert method description changes for getHardwareAddress Good to see this code go away. ------------- PR Review: https://git.openjdk.org/jdk/pull/22177#pullrequestreview-2442743947
