On Tue, 19 Nov 2024 09:49:34 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which removes the >> `getPermissions()` method from the `URLClassLoader`? This addresses >> https://bugs.openjdk.org/browse/JDK-8343150. >> >> With the SecurityManager implementation removed through JEP 486, this method >> of the `URLClassLoader` is no longer relevant. >> >> No new tests have been added. tier1 and tier2 testing is currently in >> progress. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - update the specification of > java.security.SecureClassLoader.getPermissions() > - merge latest from master branch > - 8343150: Remove URLClassLoader.getPermissions after JEP 486 integration src/java.base/share/classes/java/security/SecureClassLoader.java line 177: > 175: * > 176: * @return the permissions for the codesource. > 177: * This change will have to go in the CSR as well presumably. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22179#discussion_r1848129980
