On Fri, 22 Nov 2024 11:04:35 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which removes the >> `getPermissions()` method from the `URLClassLoader`? This addresses >> https://bugs.openjdk.org/browse/JDK-8343150. >> >> With the SecurityManager implementation removed through JEP 486, this method >> of the `URLClassLoader` is no longer relevant. >> >> No new tests have been added. tier1 and tier2 testing is currently in >> progress. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - specify URLClassLoader to reutrn empty PermissionCollection > - merge latest from master branch > - Revert "update the specification of > java.security.SecureClassLoader.getPermissions()" > > This reverts commit d6220b19a0c4b54d8fc879302baacfa90075f47f. > - update the specification of > java.security.SecureClassLoader.getPermissions() > - merge latest from master branch > - 8343150: Remove URLClassLoader.getPermissions after JEP 486 integration src/java.base/share/classes/java/net/URLClassLoader.java line 574: > 572: * {@return an {@linkplain PermissionCollection empty Permission > collection}} > 573: * > 574: * @param codesource the CodeSource Suggestion: * @param codesource the {@code CodeSource} ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22179#discussion_r1853745525
