On Tue, 19 Nov 2024 13:57:01 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8344446: Address reviewer comments
>
> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085:
>
>> 1083: }
>> 1084:
>> 1085: @SuppressWarnings({"removal", "restricted"})
>
> You can remove "removal" from the annotation.
"removal" is removed in 5e8c8d7.
> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java line 243:
>
>> 241:
>> 242: IOUtil.configureBlocking(newfd, true);
>> 243: InetSocketAddress isa = isaa[0];
>
> You don't need this variable anymore.
Removed in 5e8c8d7.
> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java line 244:
>
>> 242: IOUtil.configureBlocking(newfd, true);
>> 243: InetSocketAddress isa = isaa[0];
>> 244: sc = new SctpChannelImpl(provider(), newfd);
>
> You don't need `sc` anymore - you can just return here.
So changed in 5e8c8d7.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848663458
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848663634
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848663766
