On Wed, 5 Feb 2025 17:39:42 GMT, Mikhail Yankelevich <[email protected]> wrote:
> * fully automated the test
> * removed the race condition
> * client on a thread and server on a thread options are now run together
> automatically
The new logic looks good to me. Please wait for a review from someone from
security libs before integrating.
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 122:
> 120: }
> 121:
> 122: /* send the header */
Suggestion:
/* send the response headers and body */
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 229:
> 227: // setting up the error stream for further analysis
> 228: var errorCapture = new ByteArrayOutputStream();
> 229: var outputStream = new PrintStream(errorCapture);
Suggestion:
var errorStream = new PrintStream(errorCapture);
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 231:
> 229: var outputStream = new PrintStream(errorCapture);
> 230: var originalErr = System.err; // saving the initial error
> stream, so it can be restored
> 231: System.setErr(outputStream);
Suggestion:
System.setErr(errorStream);
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 238:
> 236: try {
> 237: new CloseKeepAliveCached();
> 238: }finally {
Suggestion:
} finally {
test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
line 246:
> 244: }
> 245:
> 246: // Looking for the result in the error stream, as it's used by
> debug (who called close SSL connection)
Suggestion:
// Parses the captured error stream, which is used by debug, to find
out who closed the SSL connection
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23469#pullrequestreview-2596638156
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1943462703
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1943466722
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1943467436
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1943467684
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1943470523
