On Thu, 6 Feb 2025 15:18:40 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apply suggestions from cr
>>
>> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com>
>
> test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
> line 50:
>
>> 48: public static final String CLOSE_THE_SSL_CONNECTION_PASSIVE = "close
>> the SSL connection (passive)";
>> 49:
>> 50: static Map cookies;
>
> These two fields, Map and ServerSocket, don't look like they're used
> anywhere. They could be deleted.
Agree, done in the next commit
> test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java
> line 241:
>
>> 239: // this will allow the error stream to be printed in case
>> of an exception inside for debugging purposes
>> 240: System.setErr(originalErr);
>> 241: if (debug) {
>
> This field is hard-coded to false which requires rebuilding to turn it on. I
> have been changing that to:
>
> `static boolean debug = Boolean.getBoolean("test.debug");`
>
> So it can be turned on with a system property.
Agree, done in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1944957029
PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r1944956832
