On Mon, 24 Mar 2025 09:52:06 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`. >> >> ### Implementation notes >> >> I deleted the `Frame` clone in tests, and rewired the test code depending on >> it to the actual `Frame`. To enable this, I relaxed the visibility of the >> actual `Frame`. I guess the `Frame` clone was introduced to have strict >> visibility in the actual `Frame`. Though this is not needed since the actual >> `Frame` is in an internal package. Plus, the fact that bug is in the `Frame` >> class hints in the direction that there should be one `Frame`. > > Volkan Yazici has updated the pull request incrementally with three > additional commits since the last revision: > > - Merge remote-tracking branch 'origin/wsEndian' into wsEndian > - Improve JavaDoc > - Add `TEST.properties` injecting `jdk.internal.net.http.websocket` Marked as reviewed by dfuchs (Reviewer). The new changes look good to me. Thanks for suggesting updating `TEST.properties` @liach ! ------------- PR Review: https://git.openjdk.org/jdk/pull/24033#pullrequestreview-2710502073 PR Comment: https://git.openjdk.org/jdk/pull/24033#issuecomment-2748233563
