On Fri, 21 Mar 2025 11:41:45 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`. >> >> ### Implementation notes >> >> I deleted the `Frame` clone in tests, and rewired the test code depending on >> it to the actual `Frame`. To enable this, I relaxed the visibility of the >> actual `Frame`. I guess the `Frame` clone was introduced to have strict >> visibility in the actual `Frame`. Though this is not needed since the actual >> `Frame` is in an internal package. Plus, the fact that bug is in the `Frame` >> class hints in the direction that there should be one `Frame`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Improve `applyVectorMask` JavaDoc > > Co-authored-by: Michael McMahon > <70538289+michael-mc-ma...@users.noreply.github.com> test/jdk/java/net/httpclient/websocket/Abort.java line 26: > 24: /* > 25: * @test > 26: * @modules java.net.http/jdk.internal.net.http.websocket Instead of adding this line to all tests, you can add a new `TEST.properties` that contains: modules = java.net.http/jdk.internal.net.http.websocket And only add `@modules` for files that require extra modules. See other `TEST.properties` in the JDK. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24033#discussion_r2009050541
