On Tue, 25 Mar 2025 09:27:15 GMT, Jaikiran Pai <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename 'separator' to 'separatorIndex', 'nameIdx' to 'nameIndex'
>
> src/java.base/share/classes/java/net/JarURLConnection.java line 186:
>
>> 184: */
>> 185: @SuppressWarnings("deprecation")
>> 186: private static URL parseJarFileURL(String spec, int separator, URL
>> connectionURL) throws MalformedURLException {
>
> Nit - maybe rename `separator` to `separatorIndex`? Here and in the other
> private method.
Thanks Jai, I have renamed 'separator' as suggested, and also 'nameIdx' for
consistency.
tier1 runs on GHA, will run tier2 locally.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24218#discussion_r2011694846
