On Tue, 25 Mar 2025 09:52:38 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename 'separator' to 'separatorIndex', 'nameIdx' to 'nameIndex'
>
> Thank you for the update. Looks fine to me.
@jaikiran GHA is green and tier2 completed with a single test failing:
java.lang.RuntimeException: 'signer certificate expired on .*. However, the JAR
will be valid' missing from stdout/stderr
at
jdk.test.lib.process.OutputAnalyzer.shouldMatch(OutputAnalyzer.java:372)
at TimestampCheck.main(TimestampCheck.java:242)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
This seems unrelated and already fixed in JDK-8352302
I'll let the earth spin just in case other reviewers have opinions, then
integrate.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24218#issuecomment-2751455069
