On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Apply review suggestions
test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 68:
> 66: import static org.junit.jupiter.api.Assertions.assertTrue;
> 67:
> 68: @SuppressWarnings("OptionalGetWithoutIsPresent")
I haven't seen this `OptionalGetWithoutIsPresent` warning before and looking
into the JDK repo I don't see it being used or recognized any place else. Is
this meant for some specific IDEs?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2024611186
