On Fri, 21 Mar 2025 15:07:17 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add import for `java.net.http.HttpClient.Version` in
>> `HttpResponseConnectionLabelTest`
>> - Fix indentation
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 87:
>
>> 85: // Primary server-client pairs
>> 86:
>> 87: private static final ServerRequestPair PRI_HTTP1 =
>> ServerRequestPair.of(HttpClient.Version.HTTP_1_1, false);
>
> Add an import for `HttpClient.Version`
Fixed in a08c0cf17423205bc91cd212823de5fd9405defc.
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 243:
>
>> 241: if (HttpClient.Version.HTTP_2.equals(pair.server.getVersion()))
>> {
>> 242: return;
>> 243: }
>
> Instead you could send a first request to warm-up the client/server and get a
> connection in the pool.
> Then you could assert that if the version is HTTP/2, the connectionLabels are
> identical (instead of different)
In that case, it would not be a _parallel_, but a _sequential_ test, and that
scenario is already tested in `testSerialRequestsToSameServer`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2009875364
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2009878596
