On Fri, 4 Apr 2025 12:47:19 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Remove timeout from `CountDownLatch::await` calls
> - Replace `@AutoClose` with a corresponding `@AfterEach` method
> - Remove IDE-specific `OptionalGetWithoutIsPresent` warning suppression
> - Improve `HttpConnection::label` JavaDoc
> - Start from 1 while labeling connections
test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 168:
> 166:
> 167: } catch (IOException ioe) {
> 168: synchronized (ServerRequestPair.class) {
Is the synchronization intentional here?
test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 173:
> 171: serverId, connectionKey,
> responseBody);
> 172: ioe.printStackTrace(System.out);
> 173: }
Shouldn't we be rethrowing these exceptions from the handler to fail the
request?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2028990169
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2028991004
