On Fri, 4 Apr 2025 15:01:48 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Remove timeout from `CountDownLatch::await` calls
>> - Replace `@AutoClose` with a corresponding `@AfterEach` method
>> - Remove IDE-specific `OptionalGetWithoutIsPresent` warning suppression
>> - Improve `HttpConnection::label` JavaDoc
>> - Start from 1 while labeling connections
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 168:
>
>> 166:
>> 167: } catch (IOException ioe) {
>> 168: synchronized (ServerRequestPair.class) {
>
> Is the synchronization intentional here?
@jaikiran, yes, otherwise the log line and the stack trace dump of consecutive
handler failures were getting intertwined into each other.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030620892
