On Thu, 10 Apr 2025 12:48:32 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient >> don't fully implement the described requirements. >> >> This PR adds the following validation: >> - pseudo-headers defined for requests are rejected in responses and push >> streams >> - pseudo-headers defined for responses are rejected in push promises >> - connection headers are rejected in responses and push streams >> >> Connection headers are still accepted in push promises; that's because some >> popular server implementations were found to echo the request headers in >> push promises, and when the original request was a HTTP/1 upgrade, the push >> promise could contain one or more headers that were prohibited in HTTP/2 but >> allowed in HTTP/1. >> >> An existing test was adapted to verify the handling of response headers. The >> modified test passes with this the changes in this PR, fails without them. >> Other tier1-3 tests continue to pass. > > src/java.net.http/share/classes/jdk/internal/net/http/common/ValidatingHeadersConsumer.java > line 46: > >> 44: REQUEST, >> 45: RESPONSE, >> 46: TRAILER > > Do we need `TRAILER`, given we don't use it, AFAIU? We have no way to relay trailers to the caller code at the moment. But we can't prevent servers to send them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24569#discussion_r2037297602
