On Mon, 28 Apr 2025 14:03:24 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Fix whitespace
>>  - Use ProtocolException for malformed headers
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java 
> line 988:
> 
>> 986:                     // connection-level HPACK decoding state
>> 987:                     if (orphanedConsumer == null || frame.getClass() != 
>> ContinuationFrame.class) {
>> 988:                         orphanedConsumer = new 
>> ValidatingHeadersConsumer(Context.RESPONSE);
> 
> Should the context be `Context.REQUEST` if `hf instanceof PushPromiseFrame`?

Good catch. Should be fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24569#discussion_r2065969415

Reply via email to