On Wed, 23 Apr 2025 18:28:48 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> java/net/URLConnection/UNCTest.java It's not completely clear to me whether this test was originally written under the assumption that a FileURLConnection for an UNC path would be returned by this test. If so, the CI instance running the test would need access to an existing UNC path like `\\jdk\LOCAL-JAVA\jdk1.4\win\README.txt`. My wild guess would be that any current CI system doesn't have this particular UNC share/file available, so instead an (unconnected) FtpURLConnection would be returned. If that's the case, then I don't think this test actually excercises the code path intended. That could only happen if the UNC path exists and a FileURLConnection was returned. To summarize: This test wants to verify that any URLConnection to an UNC path is unconnected. Instead, since the UNC path does not exists, it just tests that the FtpURLConnection is unconnected, which it always is and has been and which in any case seems unrelated to JDK-4401485 Or am I missing something here? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24657#issuecomment-2825288800
