On Wed, 23 Apr 2025 17:04:30 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 174: >> >>> 172: <a id="FileHandler"></a> >>> 173: <H2>File URL stream protocol handler properties</H2> >>> 174: <P>The following properties are used to configure the handler for URLs >>> with the {@code file://} scheme:</P> >> >> I wonder if it should say the `{@code file:}` scheme instead. Although I >> understand that the case that interests us here is >> "file://some.host/some/path". Don't change anything right now - let's see if >> we have other opinions. > >> I wonder if it should say the `{@code file:}` scheme instead. > > This seems like an improvement to me. Not really a deliberate choice to > include the slashes on my part, probably more for consistency with other > schemes under Proxy. Files with any host component should be a rarity. > >> Don't change anything right now - let's see if we have other opinions. > > Sure, we can let this simmer a bit. > I wonder if it should say the `{@code file:}` scheme instead. Although I > understand that the case that interests us here is > "file://some.host/some/path". Don't change anything right now - let's see if > we have other opinions. Nobody commented on this. Should we keep the slashes - or slash them? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24657#discussion_r2060717455