On Mon, 16 Jun 2025 07:43:54 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - include a test for AsynchronousServerSocketChannel
>> - System.err instead of System.out
>> - trim down code comment
>> - > 200 instead of >= 200
>
> src/java.base/windows/native/libnio/ch/Net.c line 225:
>
>> 223: * SOMAXCONN_HINT will adjust the value N to be within the range
>> (200, 65535).
>> 224: */
>> 225: if (backlog >= 200) {
>
> Should this is > 200 rather than >= 200?
>
> This is a Windows specific file so the comment can be trimmed down to a one
> sentence to say that SOMAXCONN_HINT is used when requested backlog is larger
> than SOMAXCONN.
Hello Alan,
> Should this is > 200 rather than >= 200?
I don't recollect why I used >= 200 when I started experimenting with these
changes a few weeks back. I think it was just an oversight. I now went back and
checked on a Windows setup and > 200 works fine. I've now updated the PR with
this change.
> This is a Windows specific file so the comment can be trimmed down to a one
> sentence to say that SOMAXCONN_HINT is used when requested backlog is larger
> than SOMAXCONN.
Done, the comment is trimmed down too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25819#discussion_r2149510540
