On Fri, 13 Jun 2025 06:36:19 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > > Test com/sun/nio/sctp/SctpChannel/CloseDescriptors.java should throw > jtreg.SkippedException when there is no lsof command or there is no SCTP in > test machine. > Before this PR, this test report Execution successful when there is no SCTP. > > > -------------------------------------------------- > TEST: com/sun/nio/sctp/SctpChannel/CloseDescriptors.java > TEST RESULT: Passed. Execution successful > -------------------------------------------------- > > > After this PR, it will report `jtreg.SkippedException` when there is no SCTP > > > -------------------------------------------------- > TEST: com/sun/nio/sctp/SctpChannel/CloseDescriptors.java > TEST RESULT: Passed. Skipped: jtreg.SkippedException: SCTP protocol is not > supported > -------------------------------------------------- > > > Change has been verified locally, test-fix only, no risk. This test-only change looks reasonable to me. I've fixed a typo in the JBS issue title, so you will have to fix this PR title too. Before integrating it would be good to verify that this test continues to be executed on a setup where SCTP is present and lsof is present. I'll run this in our CI tomorrow to verify this works as expected. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25790#pullrequestreview-2932786671
