On Mon, 16 Jun 2025 16:29:11 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Hi all, >> >> Test com/sun/nio/sctp/SctpChannel/CloseDescriptors.java should throw >> jtreg.SkippedException when there is no lsof command or there is no SCTP in >> test machine. >> Before this PR, this test report Execution successful when there is no SCTP. >> >> >> -------------------------------------------------- >> TEST: com/sun/nio/sctp/SctpChannel/CloseDescriptors.java >> TEST RESULT: Passed. Execution successful >> -------------------------------------------------- >> >> >> After this PR, it will report `jtreg.SkippedException` when there is no SCTP >> >> >> -------------------------------------------------- >> TEST: com/sun/nio/sctp/SctpChannel/CloseDescriptors.java >> TEST RESULT: Passed. Skipped: jtreg.SkippedException: SCTP protocol is not >> supported >> -------------------------------------------------- >> >> >> Change has been verified locally, test-fix only, no risk. > > This test-only change looks reasonable to me. I've fixed a typo in the JBS > issue title, so you will have to fix this PR title too. > Before integrating it would be good to verify that this test continues to be > executed on a setup where SCTP is present and lsof is present. I'll run this > in our CI tomorrow to verify this works as expected. Thanks @jaikiran I have executed this test on a setup where SCTP is present and lsof is present, but it will report failures which has been recorded by https://bugs.openjdk.org/browse/JDK-8298466. I think the test failure is unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25790#issuecomment-2978731896
